Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: supsub #217

Merged
merged 2 commits into from
Jul 3, 2022
Merged

feat: supsub #217

merged 2 commits into from
Jul 3, 2022

Conversation

Tabaie
Copy link
Contributor

@Tabaie Tabaie commented Jun 30, 2022

Integrate the superscript and subscript functions into gnark-crypto (superscript is useful for pretty printing of polynomials)

@Tabaie Tabaie requested a review from gbotrel June 30, 2022 23:12
@gbotrel
Copy link
Collaborator

gbotrel commented Jul 1, 2022

lgtm, maybe nitpicking; since you added that in utils package, some method will read like utils.Sub(..) which in the context of the rest of the library sounds a bit confusing :)

@Tabaie
Copy link
Contributor Author

Tabaie commented Jul 1, 2022

lgtm, maybe nitpicking; since you added that in utils package, some method will read like utils.Sub(..) which in the context of the rest of the library sounds a bit confusing :)

That's a great point. I'll change it to ToSubscript.

@Tabaie Tabaie changed the base branch from master to develop July 3, 2022 19:58
@Tabaie Tabaie merged commit 04aca0c into develop Jul 3, 2022
@Tabaie Tabaie deleted the string-utils branch July 3, 2022 19:59
@gbotrel gbotrel mentioned this pull request Aug 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbotrel gbotrel gbotrel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tabaie @gbotrel